[webkit-reviews] review granted: [Bug 53104] Intermittent crash in fast/files/read-blob-async.html on the GTK+ debug bots : [Attachment 81319] 4th patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Mon Feb 7 13:09:55 PST 2011
David Levin <levin at chromium.org> has granted Jian Li <jianli at chromium.org>'s
request for review:
Bug 53104: Intermittent crash in fast/files/read-blob-async.html on the GTK+
debug bots
https://bugs.webkit.org/show_bug.cgi?id=53104
Attachment 81319: 4th patch
https://bugs.webkit.org/attachment.cgi?id=81319&action=review
------- Additional Comments from David Levin <levin at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=81319&action=review
> Source/WebCore/ChangeLog:27
> + immediately, as in the GTK+ case.
This line looks like a left over from some editting.
> Source/WebCore/platform/network/BlobResourceHandle.cpp:199
> + // Do the start later because this method is part of the async
creation and we want it to finish quickly.
I think you only need to explain why like this:
"Finish this async call quickly and return."
> Source/WebCore/platform/network/BlobResourceHandle.cpp:201
> +
Remove extra blank line.
> Source/WebCore/platform/network/BlobResourceHandle.cpp:608
> + // If we notify the client now, BlobResourceHandle will get disposed
while we still have BlobResourceHandle calls in the stack.
The second sentence is sufficient.
More information about the webkit-reviews
mailing list