[webkit-reviews] review granted: [Bug 52836] [GTK] Move scrollbar rendering out of gtk2drawing.c : [Attachment 79787] Patch

[bugzilla-daemon at webkit.org]

Gustavo Noronha (kov) <gns at gnome.org> has granted Martin Robinson
<mrobinson at webkit.org>'s request for review:
Bug 52836: [GTK] Move scrollbar rendering out of gtk2drawing.c
https://bugs.webkit.org/show_bug.cgi?id=52836

Attachment 79787: Patch
https://bugs.webkit.org/attachment.cgi?id=79787&action=review

------- Additional Comments from Gustavo Noronha (kov) <gns at gnome.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=79787&action=review

> Source/WebCore/platform/gtk/ScrollbarThemeGtk2.cpp:112
> +    // properly the theme may draw not draw the thumb borders properly.

s/draw not/not/, right?

> Source/WebCore/platform/gtk/ScrollbarThemeGtk2.cpp:186
> +    gfloat arrowScaling;

Xan does not approve of using g* types when they're just typedefs of the
standard C ones.

> Source/WebCore/platform/gtk/WidgetRenderingContext.cpp:155
> +void WidgetRenderingContext::gtkPaintBox(const IntRect& rect, GtkWidget*
widget, GtkStateType stateType, GtkShadowType shadowType, const gchar* detail,
bool adjustAllocation)

Would it hurt to remove the bool and always perform the allocation? I mean,
except for the (negligible?) extra work? It might make this more future-proof,
and we can toss this additional argument.