[webkit-reviews] review denied: [Bug 52867] OwnArraryPtr.=?UTF-8?Q?h=20uses=20deleteOwnedPtr=20but=20doesn=E2=80=99t=20include=20OwnPtrCommon?=.h : [Attachment 81438] fixed cr-mac build

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has denied Ryosuke Niwa <rniwa at webkit.org>'s
request for review:
Bug 52867: OwnArraryPtr.h uses deleteOwnedPtr but doesn’t include
OwnPtrCommon.h
https://bugs.webkit.org/show_bug.cgi?id=52867

Attachment 81438: fixed cr-mac build
https://bugs.webkit.org/attachment.cgi?id=81438&action=review

------- Additional Comments from Darin Adler <darin at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=81438&action=review

Exciting to see this. Looking forward to it landing. review- because of the
JavaScriptCore registers issues.

> Source/JavaScriptCore/runtime/Arguments.h:232
>	   Register* registerArray = new Register[registerArraySize];
>	   memcpy(registerArray, d->registers - registerOffset,
registerArraySize * sizeof(Register));
> -	   d->registerArray.set(registerArray);
> +	   d->registerArray = registerArray;
>	   d->registers = registerArray + registerOffset;

Needs an adoptArrayPtr. Probably won’t compile. I think this is may be why EWS
bots are failing to build.

> Source/JavaScriptCore/runtime/JSVariableObject.h:165
>      inline void JSVariableObject::setRegisters(Register* registers,
Register* registerArray)
>      {
>	   ASSERT(registerArray != d->registerArray.get());
> -	   d->registerArray.set(registerArray);
> +	   d->registerArray = registerArray;
>	   d->registers = registers;
>      }

Needs PassOwnArrayPtr. Same as above.