[webkit-reviews] review denied: [Bug 53840] nrwt multiprocessing: conclude refactoring of dump_render_tree_thread and single_test_runner : [Attachment 81342] Patch

[bugzilla-daemon at webkit.org]

Ojan Vafai <ojan at chromium.org> has denied Dirk Pranke <dpranke at chromium.org>'s
request for review:
Bug 53840: nrwt multiprocessing: conclude refactoring of
dump_render_tree_thread and single_test_runner
https://bugs.webkit.org/show_bug.cgi?id=53840

Attachment 81342: Patch
https://bugs.webkit.org/attachment.cgi?id=81342&action=review

------- Additional Comments from Ojan Vafai <ojan at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=81342&action=review

> Tools/ChangeLog:23
> +	   new-run-webkit-tests: move remaining common logic out of
> +	   dump_render_tree_thread into single_test_runner so that we can
> +	   reuse it in the new multiprocessing worker class as well.
> +
> +	   https://bugs.webkit.org/show_bug.cgi?id=53840
> +
> +	   *
Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
> +	   *
Scripts/webkitpy/layout_tests/layout_package/single_test_runner.py:
> + 
> +2011-01-10  Dirk Pranke  <dpranke at chromium.org>
> +
> +	   Reviewed by NOBODY (OOPS!).
> +
> +	   new-run-webkit-tests: refactor common logic out of
> +	   dump_render_tree_thread into single_test_runner so that we can
> +	   reuse it in the new multiprocessing worker class as well.
> +
> +	   *
Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
> +	   *
Scripts/webkitpy/layout_tests/layout_package/single_test_runner.py:

duplicate entry

>
Tools/Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:2
05
> +		       self._http_lock_wait_begin = time.time()

Should you move http_lock_wait_* as well? Seems like it would make sense to
keep it with the logic that starts/stops the server.