[webkit-reviews] review granted: [Bug 53880] Use bloom filter for descendant selector filtering : [Attachment 81416] attempted build fixes for various build systems
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Sun Feb 6 12:07:29 PST 2011
Maciej Stachowiak <mjs at apple.com> has granted Antti Koivisto
<koivisto at iki.fi>'s request for review:
Bug 53880: Use bloom filter for descendant selector filtering
https://bugs.webkit.org/show_bug.cgi?id=53880
Attachment 81416: attempted build fixes for various build systems
https://bugs.webkit.org/attachment.cgi?id=81416&action=review
------- Additional Comments from Maciej Stachowiak <mjs at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=81416&action=review
r=me with one minor comment
> Source/JavaScriptCore/wtf/BloomFilter.h:77
> + char m_table[tableSize];
I'd suggest using "unsigned char" or uint8_t for this, since it's using char as
a byte, not a character, and this avoids pain on platforms where char is signed
by default.
More information about the webkit-reviews
mailing list