[webkit-reviews] review granted: [Bug 53850] Make WebKit's fragment cannonicalization match other browsers : [Attachment 81418] updated patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Sun Feb 6 11:37:04 PST 2011


Adam Barth <abarth at webkit.org> has granted Eric Seidel <eric at webkit.org>'s
request for review:
Bug 53850: Make WebKit's fragment cannonicalization match other browsers
https://bugs.webkit.org/show_bug.cgi?id=53850

Attachment 81418: updated patch
https://bugs.webkit.org/attachment.cgi?id=81418&action=review

------- Additional Comments from Adam Barth <abarth at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=81418&action=review

> Source/WebCore/platform/KURL.cpp:1012
> +	   // FIXME: We should be decoding any non-ascii characters (above
0x80),
> +	   // however at this point we don't have the full UChar anymore, just
a char.

This FIXME isn't correct.  The decoding has already happened at this point.


More information about the webkit-reviews mailing list