[webkit-reviews] review granted: [Bug 53874] [Qt] Clear page's groupName even when not in DRT : [Attachment 81405] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Sun Feb 6 08:37:34 PST 2011
Andreas Kling <kling at webkit.org> has granted Robert Hogan <robert at webkit.org>'s
request for review:
Bug 53874: [Qt] Clear page's groupName even when not in DRT
https://bugs.webkit.org/show_bug.cgi?id=53874
Attachment 81405: Patch
https://bugs.webkit.org/attachment.cgi?id=81405&action=review
------- Additional Comments from Andreas Kling <kling at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=81405&action=review
r=me
> Source/WebKit/qt/WebCoreSupport/ChromeClientQt.cpp:310
> + m_webPage->d->page->setGroupName(QString());
Use String() instead of QString() here to avoid the extra implicit conversion.
More information about the webkit-reviews
mailing list