[webkit-reviews] review canceled: [Bug 50916] Add support for dir=auto : [Attachment 80968] Patch.

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Sat Feb 5 15:04:57 PST 2011


Yael <yael.aharon at nokia.com> has canceled Yael <yael.aharon at nokia.com>'s
request for review:
Bug 50916: Add support for dir=auto
https://bugs.webkit.org/show_bug.cgi?id=50916

Attachment 80968: Patch.
https://bugs.webkit.org/attachment.cgi?id=80968&action=review

------- Additional Comments from Yael <yael.aharon at nokia.com>
When an element has dir attribute with value "auto", call defaultWritingMode to
find its directionality.
Added a flag SelfOrAncestorHasDirAutoFlag, and added hooks in the DOM to set
and check this flag. This flag is set on every node between an element with
dir=auto attribute and its first text node. Changes in the DOM between those
elements will trigger re-evaluating the directionality, but changed not between
those element do not need to be concerned.
The DOM hooks were added to childrenChanged, and to parseMappedAttribute. The
directionality is evaluated when children are added, but not when they are
removed. Once they are re-added, the directionality will be evaluated.

Added 2 static CSSMutableStyleDeclarations to be used for elements with
dir=auto.
We cannot use the mapped declaration, because it can take only one value.


More information about the webkit-reviews mailing list