[webkit-reviews] review granted: [Bug 53398] Use Document::encoding() instead of DocumentWriter::encoding() : [Attachment 81360] Patch

[bugzilla-daemon at webkit.org]

Alexey Proskuryakov <ap at webkit.org> has granted Patrick R. Gansterer
<paroga at paroga.com>'s request for review:
Bug 53398: Use Document::encoding() instead of DocumentWriter::encoding()
https://bugs.webkit.org/show_bug.cgi?id=53398

Attachment 81360: Patch
https://bugs.webkit.org/attachment.cgi?id=81360&action=review

------- Additional Comments from Alexey Proskuryakov <ap at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=81360&action=review

Another thing to test is whether the main document decoding starts using the
new encoding after assignment to charset. That's obviously tricky, as decoding
happens ahead of execution - but as far as I can tell, that's completely broken
in WebKit now. Changing TextResourceDecoder charset on the fly resets it,
dropping buffered characters, so assigning to document.charset means that a
decoding error will occur at some later point.

> LayoutTests/fast/encoding/external-script-charset-expected.txt:4
>  PASS
> +PASS

Would be nice to explain what these subtests are, like it's done in other
tests.