[webkit-reviews] review granted: [Bug 53380] [Qt] WebKit does not build on Mac with WebKit 2 : [Attachment 81363] Patch

[bugzilla-daemon at webkit.org]

Andreas Kling <kling at webkit.org> has granted Benjamin Poulain
<benjamin.poulain at nokia.com>'s request for review:
Bug 53380: [Qt] WebKit does not build on Mac with WebKit 2
https://bugs.webkit.org/show_bug.cgi?id=53380

Attachment 81363: Patch
https://bugs.webkit.org/attachment.cgi?id=81363&action=review

------- Additional Comments from Andreas Kling <kling at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=81363&action=review

r=me

> Source/WebKit2/Platform/qt/SharedMemoryQt.cpp:206
> +    while ((fcntl(duplicatedHandle, F_SETFD,  FD_CLOEXEC |
accessModeFile(protection)) == -1)) {

Extra space before FD_CLOEXEC.

> Source/WebKit2/UIProcess/WebPageProxy.cpp:1093
> +#if defined(__APPLE__) && !PLATFORM(QT)

This is quite ugly. I wish we'd use something other than __APPLE__ for
mac-port-specific stuff.