[webkit-reviews] review denied: [Bug 52039] Make rebaseline server usable with bot results : [Attachment 81310] Patch

[bugzilla-daemon at webkit.org]

Eric Seidel <eric at webkit.org> has denied Mihai Parparita
<mihaip at chromium.org>'s request for review:
Bug 52039: Make rebaseline server usable with bot results
https://bugs.webkit.org/show_bug.cgi?id=52039

Attachment 81310: Patch
https://bugs.webkit.org/attachment.cgi?id=81310&action=review

------- Additional Comments from Eric Seidel <eric at webkit.org>
I think to do this right, this needs to be an object.  It's logic is wholly
seperable from the rebaseline server.  But it's fine to have the object live in
that file if you like.

The test looks fine.  You might want some finer-grain tests of the individual
methods, but the full-sytem test you have looks fine.

Yes, we might delete this.  But when we delete this, we'll delete the whole
object and associated tests. Not some random group of free functions. :)  When
we always have a unexpectedresults.json file to read then we don't need ot use
this code at all.