[webkit-reviews] review granted: [Bug 53821] WebKit2 doesn't hide mouse pointer on keypress : [Attachment 81311] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Feb 4 15:55:42 PST 2011


mitz at webkit.org has granted Darin Adler <darin at apple.com>'s request for review:
Bug 53821: WebKit2 doesn't hide mouse pointer on keypress
https://bugs.webkit.org/show_bug.cgi?id=53821

Attachment 81311: Patch
https://bugs.webkit.org/attachment.cgi?id=81311&action=review

------- Additional Comments from mitz at webkit.org
View in context: https://bugs.webkit.org/attachment.cgi?id=81311&action=review

> Source/WebKit2/UIProcess/API/mac/PageClientImpl.mm:314
>      if ([nativeEvent type] == NSKeyDown) {

Perhaps the test should be reversed and an early return added so that the
entire body is not indented.


More information about the webkit-reviews mailing list