[webkit-reviews] review granted: [Bug 52831] Crash in glDrawArrays with NaCl crystal model : [Attachment 81293] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Feb 4 15:33:50 PST 2011


Kenneth Russell <kbr at google.com> has granted Zhenyao Mo <zmo at google.com>'s
request for review:
Bug 52831: Crash in glDrawArrays with NaCl crystal model
https://bugs.webkit.org/show_bug.cgi?id=52831

Attachment 81293: Patch
https://bugs.webkit.org/attachment.cgi?id=81293&action=review

------- Additional Comments from Kenneth Russell <kbr at google.com>
The workaround looks fine. It's unfortunate how complicated it is. The test of
whether vertex attribute 0 has ever been used in this context before is
disconcerting. Please do make sure a bug gets filed against Apple's OpenGL
implementation so that this code might be removed at some point.


More information about the webkit-reviews mailing list