[webkit-reviews] review granted: [Bug 53810] WebKit2 clients fail to launch on Windows if client exe is in a different directory from WebKit : [Attachment 81284] Patch

[bugzilla-daemon at webkit.org]

Adam Roben (aroben) <aroben at apple.com> has granted Steve Falkenburg
<sfalken at apple.com>'s request for review:
Bug 53810: WebKit2 clients fail to launch on Windows if client exe is in a
different directory from WebKit
https://bugs.webkit.org/show_bug.cgi?id=53810

Attachment 81284: Patch
https://bugs.webkit.org/attachment.cgi?id=81284&action=review

------- Additional Comments from Adam Roben (aroben) <aroben at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=81284&action=review

> Source/WebKit2/win/MainWin.cpp:50
> +    ::GetModuleFileNameW(0, webKitPath, ARRAYSIZE(webKitPath));

You could also use _countof or WTF_ARRAY_LENGTH. Maybe the latter is best,
since it can be used in cross-platform code, too?

> Source/WebKit2/win/MainWin.cpp:57
> +    // set to 0. We want both the WebKit client app DLL path and the WebKit
directory DLL path in
> +    // the DLL search order, and we want the current directory set to the
WebKit client app path.
> +    ::SetDllDirectoryW(webKitPath);

How does this guarantee that the "client app DLL path" is in the DLL search
order, or that the current directory is set to the WebKit client app path?