[webkit-reviews] review granted: [Bug 52819] Crash in WebCore::HistoryController::itemsAreClones : [Attachment 81128] Patch

[bugzilla-daemon at webkit.org]

Mihai Parparita <mihaip at chromium.org> has granted Charles Reis
<creis at chromium.org>'s request for review:
Bug 52819: Crash in WebCore::HistoryController::itemsAreClones
https://bugs.webkit.org/show_bug.cgi?id=52819

Attachment 81128: Patch
https://bugs.webkit.org/attachment.cgi?id=81128&action=review

------- Additional Comments from Mihai Parparita <mihaip at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=81128&action=review

> LayoutTests/fast/history/history-back-forward-within-subframe-hash.html:3
> +onload = function() {

Nit: There isn't a formal style guide for JavaScript used in layout tests, but
generally the convention is to follow the WebKit C++ style (four space indents,
function braces on their own line).

>
LayoutTests/fast/history/resources/history-back-forward-within-subframe-hash-2.
html:15
> +	 parent.document.getElementById("result").innerText = "First visit";

If you use the js-test framework (see
same-document-iframes-changing-fragment.html,
history-traversal-is-asynchronous.html, and a few other tests in the
directory), then you can turn these into log statements instead of replacing
the result text. That makes failures easier to debug, since you can more
clearly see at what stage the actual output started to deviate from the
expected one.