[webkit-reviews] review denied: [Bug 53722] Hook up WebGraphicsContext3D::setContextLostCallback. : [Attachment 81163] Patch

[bugzilla-daemon at webkit.org]

Kenneth Russell <kbr at google.com> has denied Alexey Marinichev
<amarinichev at chromium.org>'s request for review:
Bug 53722: Hook up WebGraphicsContext3D::setContextLostCallback.
https://bugs.webkit.org/show_bug.cgi?id=53722

Attachment 81163: Patch
https://bugs.webkit.org/attachment.cgi?id=81163&action=review

------- Additional Comments from Kenneth Russell <kbr at google.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=81163&action=review

Looks good overall. r- for the minor issue of the naked new which needs to be
cleaned up. One question.

> Source/WebCore/html/canvas/WebGLRenderingContext.cpp:378
> +    m_context->setContextLostCallback(new
WebGLRenderingContextLostCallback(this));

naked new. Should use adoptPtr(new ...);

> Source/WebKit/chromium/src/GraphicsContext3DChromium.cpp:1110
> +    m_impl->setContextLostCallback(m_contextLostCallbackAdapter.get());

Is there an ownership issue here? Does the WebGraphicsContext3D take ownership
of the passed callback like GraphicsContext3D and WebGLRenderingContext or not?