[webkit-reviews] review granted: [Bug 53798] Assertion failure in WebInspectorProxy::platformClose closing main window when inspecting a popup window, or when running regression tests : [Attachment 81264] [PATCH] Fix

[bugzilla-daemon at webkit.org]

Adam Roben (aroben) <aroben at apple.com> has granted Brian Weinstein
<bweinstein at apple.com>'s request for review:
Bug 53798: Assertion failure in WebInspectorProxy::platformClose closing main
window when inspecting a popup window, or when running regression tests
https://bugs.webkit.org/show_bug.cgi?id=53798

Attachment 81264: [PATCH] Fix
https://bugs.webkit.org/attachment.cgi?id=81264&action=review

------- Additional Comments from Adam Roben (aroben) <aroben at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=81264&action=review

> Source/WebKit2/UIProcess/win/WebInspectorProxyWin.cpp:178
> +    if (m_isVisible) {
> +	   ASSERT(m_inspectorWindow);
> +	   ASSERT(m_inspectorView);
> +    }

To get rid of the if in Release builds, you could do:

ASSERT(!m_isVisible || m_inspectorWindow);
ASSERT(!m_isVisible || m_inspectorView);

> Source/WebKit2/UIProcess/win/WebInspectorProxyWin.cpp:181
> +	   ASSERT(::IsWindow(m_inspectorWindow));

Have you verified that this is true even when the inspector is docked?