[webkit-reviews] review denied: [Bug 53117] Invalidate rect doesn't work for windowless plugins on Chromium : [Attachment 81249] removed debugging code form HTML file

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Feb 4 12:24:42 PST 2011


Kenneth Russell <kbr at google.com> has denied  review:
Bug 53117: Invalidate rect doesn't work for windowless plugins on Chromium
https://bugs.webkit.org/show_bug.cgi?id=53117

Attachment 81249: removed debugging code form HTML file
https://bugs.webkit.org/attachment.cgi?id=81249&action=review

------- Additional Comments from Kenneth Russell <kbr at google.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=81249&action=review

> Source/WebKit/chromium/src/WebPluginContainerImpl.cpp:136
> +  renderer->repaintRectangle(dirtyRect);

Indentation doesn't follow WebKit style in this file.

> LayoutTests/platform/chromium-gpu/plugin/invalidate_rect-expected.txt:8
>    + LF

You should disable "enable-auto-props = yes" in ~/.subversion/config when
adding these new files to the WebKit repository.


More information about the webkit-reviews mailing list