[webkit-reviews] review requested: [Bug 53749] Templatize KURLGooglePrivate::init : [Attachment 81258] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Fri Feb 4 11:47:10 PST 2011
Cosmin Truta <ctruta at chromium.org> has asked for review:
Bug 53749: Templatize KURLGooglePrivate::init
https://bugs.webkit.org/show_bug.cgi?id=53749
Attachment 81258: Patch
https://bugs.webkit.org/attachment.cgi?id=81258&action=review
------- Additional Comments from Cosmin Truta <ctruta at chromium.org>
(In reply to comment #4)
> This is by design and not a bogus failure.
Ok. I am resubmitting the patch, with the comments updated. check-webkit-style
is now passing.
I replaced "NULL" with "0", "'\0'" or "null" as appropriate. I kept using the
(dictionary word) "null" because it makes sense to refer to the "null string",
and also because it has semantic meaning in the underlying classes (e.g.
CString::isNull).
In fact, before this change, the spellings "null" and "NULL" were used
interchangeably.
More information about the webkit-reviews
mailing list