[webkit-reviews] review granted: [Bug 53780] Crash log links in results.html should include the function that crashed on Mac : [Attachment 81235] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Feb 4 09:52:06 PST 2011


David Kilzer (ddkilzer) <ddkilzer at webkit.org> has granted Adam Roben (aroben)
<aroben at apple.com>'s request for review:
Bug 53780: Crash log links in results.html should include the function that
crashed on Mac
https://bugs.webkit.org/show_bug.cgi?id=53780

Attachment 81235: Patch
https://bugs.webkit.org/attachment.cgi?id=81235&action=review

------- Additional Comments from David Kilzer (ddkilzer) <ddkilzer at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=81235&action=review

r=me

> Tools/Scripts/old-run-webkit-tests:2017
> +	       $location = $functionAndOffset;

You should return "$module: $functionAndOffset" to match Windows here.


More information about the webkit-reviews mailing list