[webkit-reviews] review requested: [Bug 53772] Use static_cast and other style cleanup in YarrInterpreter.cpp : [Attachment 81227] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Feb 4 09:08:56 PST 2011


David Kilzer (ddkilzer) <ddkilzer at webkit.org> has asked  for review:
Bug 53772: Use static_cast and other style cleanup in YarrInterpreter.cpp
https://bugs.webkit.org/show_bug.cgi?id=53772

Attachment 81227: Patch
https://bugs.webkit.org/attachment.cgi?id=81227&action=review

------- Additional Comments from David Kilzer (ddkilzer) <ddkilzer at webkit.org>
Reviewed by NOBODY (OOPS!).

* yarr/YarrInterpreter.cpp:
(JSC::Yarr::Interpreter::InputStream::readChecked): Use
static_cast.
(JSC::Yarr::Interpreter::InputStream::checkInput): Remove
unnecessary else block.
(JSC::Yarr::Interpreter::matchAssertionEOL): Ditto.
(JSC::Yarr::Interpreter::backtrackBackReference): Ditto.
(JSC::Yarr::ByteCompiler::emitDisjunction): Use static_cast.
---
 2 files changed, 24 insertions(+), 9 deletions(-)


More information about the webkit-reviews mailing list