[webkit-reviews] review granted: [Bug 14861] run-webkit-tests should link to Mac crash logs in results.html : [Attachment 81224] Link to Mac crash logs from results.html

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Feb 4 08:51:35 PST 2011


David Kilzer (ddkilzer) <ddkilzer at webkit.org> has granted Adam Roben (aroben)
<aroben at apple.com>'s request for review:
Bug 14861: run-webkit-tests should link to Mac crash logs in results.html
https://bugs.webkit.org/show_bug.cgi?id=14861

Attachment 81224: Link to Mac crash logs from results.html
https://bugs.webkit.org/attachment.cgi?id=81224&action=review

------- Additional Comments from David Kilzer (ddkilzer) <ddkilzer at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=81224&action=review

r=me!

> Tools/Scripts/old-run-webkit-tests:1763
> +	   if (my @reportCrashPIDs = sort map { /^\s*(\d+)/; $1 } grep {
/ReportCrash/ } `ps x`) {

Nit:  I prefer to use "/bin/ps" instead of just "ps", but it only matters if
more than one 'ps' is installed in the path (e.g., by an attacker or MacPorts).


More information about the webkit-reviews mailing list