[webkit-reviews] review denied: [Bug 44620] Web Inspector: reflect changes to styles when they happen outside inspector. : [Attachment 81199] [PATCH] Comments addressed

[bugzilla-daemon at webkit.org]

Pavel Feldman <pfeldman at chromium.org> has denied Alexander Pavlov (apavlov)
<apavlov at chromium.org>'s request for review:
Bug 44620: Web Inspector: reflect changes to styles when they happen outside
inspector.
https://bugs.webkit.org/show_bug.cgi?id=44620

Attachment 81199: [PATCH] Comments addressed
https://bugs.webkit.org/attachment.cgi?id=81199&action=review

------- Additional Comments from Pavel Feldman <pfeldman at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=81199&action=review

> Source/WebCore/css/CSSMutableStyleDeclaration.cpp:474
> +	       if (styleAttributeChange == FullStyleChange &&
m_node->document())

I think there has been misunderstanding: your boolean values had different
meaning than the ones in StyleChangeType. What you are fighting was dupe in the
didModifyAttr notification. You should either find out what negative
implications this dupe has or come up with a separate 
InspectorInstrumentation::inlineStyleNeedsRecalc(m_node) signal that you would
fire here unconditionally.

> Source/WebCore/inspector/front-end/StylesSidebarPane.js:1770
> +	      
WebInspector.panels.elements.sidebarPanes.styles.isModifyingStyle = true;

Please pass styles pane into section instead.