[webkit-reviews] review denied: [Bug 53756] Refactor and/or split and/or rename the extend-selection tests to be clearer what they're doing, and able to be run manually : [Attachment 81186] Patch

[bugzilla-daemon at webkit.org]

Ryosuke Niwa <rniwa at webkit.org> has denied Benjamin (Ben) Kalman
<kalman at chromium.org>'s request for review:
Bug 53756: Refactor and/or split and/or rename the extend-selection tests to be
clearer what they're doing, and able to be run manually
https://bugs.webkit.org/show_bug.cgi?id=53756

Attachment 81186: Patch
https://bugs.webkit.org/attachment.cgi?id=81186&action=review

------- Additional Comments from Ryosuke Niwa <rniwa at webkit.org>
Making tests manually runnable is good but all these rewrites of script isn't
that great.  It's really hard to see that new tests are testing the same things
the old tests were testing.  In general, we must be careful when modifying
tests because subtle differences may affect what tests do.  At least, we should
separate refactoring and changes to make it manually runnable.

I don't think separating the line boundary tests into LTR/RTL tests is a good
idea because having both results on one test has helped us catching regressions
in either result since extend-selection-* tests are written so that LTR/RTL
results should match.