[webkit-reviews] review granted: [Bug 53740] Allow platforms to specify if the placeholder should be visible when text controls are focused : [Attachment 81161] Patch

[bugzilla-daemon at webkit.org]

mitz at webkit.org has granted Adele Peterson <adele at apple.com>'s request for
review:
Bug 53740: Allow platforms to specify if the placeholder should be visible when
text controls are focused
https://bugs.webkit.org/show_bug.cgi?id=53740

Attachment 81161: Patch
https://bugs.webkit.org/attachment.cgi?id=81161&action=review

------- Additional Comments from mitz at webkit.org
View in context: https://bugs.webkit.org/attachment.cgi?id=81161&action=review

You are missing a LayoutTests/ChangeLog.

> Source/WebCore/html/HTMLTextAreaElement.cpp:280
> +   
const_cast<HTMLTextAreaElement*>(this)->updatePlaceholderVisibility(false);

Is this not needed for text fields too?