[webkit-reviews] review granted: [Bug 53720] new-run-webkit-tests: fix normalization of paths on windows when gathering files : [Attachment 81122] Patch

[bugzilla-daemon at webkit.org]

Mihai Parparita <mihaip at chromium.org> has granted Dirk Pranke
<dpranke at chromium.org>'s request for review:
Bug 53720: new-run-webkit-tests: fix normalization of paths on windows when
gathering files
https://bugs.webkit.org/show_bug.cgi?id=53720

Attachment 81122: Patch
https://bugs.webkit.org/attachment.cgi?id=81122&action=review

------- Additional Comments from Mihai Parparita <mihaip at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=81122&action=review

> Tools/Scripts/webkitpy/layout_tests/port/test_files.py:66
> +def normalize(fs, base_dir, paths):

Nit: Consistent naming for Filesystem parameters (filesystem vs. fs) seems like
a good idea.

> Tools/Scripts/webkitpy/layout_tests/port/test_files_unittest.py:91
> +	   # results that we get in test_forward_subpath().

Did you mean to say test_mocked_win here?