[webkit-reviews] review denied: [Bug 53690] IndexedDB: Cursors should skip deleted entries : [Attachment 81073] Patch

[bugzilla-daemon at webkit.org]

Jeremy Orlow <jorlow at chromium.org> has denied Hans Wennborg
<hans at chromium.org>'s request for review:
Bug 53690: IndexedDB: Cursors should skip deleted entries
https://bugs.webkit.org/show_bug.cgi?id=53690

Attachment 81073: Patch
https://bugs.webkit.org/attachment.cgi?id=81073&action=review

------- Additional Comments from Jeremy Orlow <jorlow at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=81073&action=review

Maybe you should make your test function a bit more generic and then you can
specifically test more corner cases: the first element, the last, the current,
the previous, a couple previous, the next, and a couple later.	(The last is
all you test now.)  I don't think it'll take too much time and it'll definitely
make this more robust in the future.

Looks great though.

> Source/WebCore/storage/IDBCursorBackendImpl.cpp:104
> +

newline seems kinda useless....you could even use a ternary operator if you
wanted...don't care much either way tho