[webkit-reviews] review granted: [Bug 53664] XSSFilter shouldn't bother to analyze pages without "injection" characters in the request : [Attachment 81037] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Feb 3 14:24:28 PST 2011


Daniel Bates <dbates at webkit.org> has granted Eric Seidel <eric at webkit.org>'s
request for review:
Bug 53664: XSSFilter shouldn't bother to analyze pages without "injection"
characters in the request
https://bugs.webkit.org/show_bug.cgi?id=53664

Attachment 81037: Patch
https://bugs.webkit.org/attachment.cgi?id=81037&action=review

------- Additional Comments from Daniel Bates <dbates at webkit.org>
Thank you Eric for looking over this patch. I was also not very satisfied with
the m_isInitialized, but its presence isn't terrible. Moreover, I envisioned
that we will perform some clean up iterations on this code once all the major
pieces have been moved into place.

If you see any correctness issues with this patch then feel free to override my
review and help improve the code.


More information about the webkit-reviews mailing list