[webkit-reviews] review granted: [Bug 52594] Move chromium iframe shim code to cross-platform file : [Attachment 81107] Patch

[bugzilla-daemon at webkit.org]

Darin Fisher (:fishd, Google) <fishd at chromium.org> has granted Robert Hogan
<robert at webkit.org>'s request for review:
Bug 52594: Move chromium iframe shim code to cross-platform file
https://bugs.webkit.org/show_bug.cgi?id=52594

Attachment 81107: Patch
https://bugs.webkit.org/attachment.cgi?id=81107&action=review

------- Additional Comments from Darin Fisher (:fishd, Google)
<fishd at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=81107&action=review

Looks good, just one remaining nit.  R=me w/ that resolved.

> Source/WebCore/plugins/IFrameShimSupport.h:30
> +void getPluginOcclusions(Element*, Widget* parentWidget, const IntRect&
frameRect, Vector<IntRect>& cutOutRects);

nit-picky nit: rename |cutOutRects| to |occlusions| to be consistent.