[webkit-reviews] review requested: [Bug 53398] Use Document::encoding() instead of DocumentWriter::encoding() : [Attachment 80594] Patch

[bugzilla-daemon at webkit.org]

Patrick R. Gansterer <paroga at paroga.com> has asked  for review:
Bug 53398: Use Document::encoding() instead of DocumentWriter::encoding()
https://bugs.webkit.org/show_bug.cgi?id=53398

Attachment 80594: Patch
https://bugs.webkit.org/attachment.cgi?id=80594&action=review

------- Additional Comments from Patrick R. Gansterer <paroga at paroga.com>
Document::encoding() and DocumentWriter::encoding() are always the same.

Document::setDecoder() will be called at
http://trac.webkit.org/browser/trunk/Source/WebCore/loader/DocumentWriter.cpp?r
ev=76872#L133
http://trac.webkit.org/browser/trunk/Source/WebCore/loader/DocumentWriter.cpp?r
ev=76872#L177
where Document::encoding will be set to DocumentWriter::encoding

There is one place where this happens in the other direction:
http://trac.webkit.org/browser/trunk/Source/WebCore/loader/FrameLoader.cpp?rev=
76872#L2166

And there is one call where we set Document::encoding and don't have a
DocumentWriter:
http://trac.webkit.org/browser/trunk/Source/WebCore/xml/XSLTProcessor.cpp?rev=7
6872#L92