[webkit-reviews] review requested: [Bug 47264] Introduce the device element as an experimental feature : [Attachment 81085] Updated patch

[bugzilla-daemon at webkit.org]

Adam Bergkvist <adam.bergkvist at ericsson.com> has asked	for review:
Bug 47264: Introduce the device element as an experimental feature
https://bugs.webkit.org/show_bug.cgi?id=47264

Attachment 81085: Updated patch
https://bugs.webkit.org/attachment.cgi?id=81085&action=review

------- Additional Comments from Adam Bergkvist <adam.bergkvist at ericsson.com>
Thank you for your comments.

1. Build failures
Filed bug (https://bugs.webkit.org/show_bug.cgi?id=53672) with patch that
modifies make_names.pl to not unconditionally include HTMLDeviceElement.h and
JSHTMLDeviceElement.h.

2. Parser modification
Filed bug (http://www.w3.org/Bugs/Public/show_bug.cgi?id=11935) to include
device in the list of self-closing elements in the specification.
Added parser test that demonstrates the behavior.

3. "#if 0"
Replaced with FIXME.

4. C-style casts
Fixed.

5. Synchronous dialog
Added callback from dialog.

6. Synchronous device list creation
Moved list creation to platform dialog code.