[webkit-reviews] review granted: [Bug 53687] [v8] Bail out if to string conversion returned empty handle : [Attachment 81071] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Feb 3 10:16:48 PST 2011


Adam Barth <abarth at webkit.org> has granted anton muhin <antonm at chromium.org>'s
request for review:
Bug 53687: [v8] Bail out if to string conversion returned empty handle
https://bugs.webkit.org/show_bug.cgi?id=53687

Attachment 81071: Patch
https://bugs.webkit.org/attachment.cgi?id=81071&action=review

------- Additional Comments from Adam Barth <abarth at webkit.org>
Generally speaking, we'd rather fix the root cause of the issue that bandaid
over it like this.  Maybe add an ASSERT_NOT_REACHED to emphasize that it
shouldn't happen?  Ideally we'd remove this code once we fixed the underlying
bug...


More information about the webkit-reviews mailing list