[webkit-reviews] review granted: [Bug 53686] Web Inspector: remove settings related methods from InspectorClient : [Attachment 81069] Patch

[bugzilla-daemon at webkit.org]

Pavel Feldman <pfeldman at chromium.org> has granted Yury Semikhatsky
<yurys at chromium.org>'s request for review:
Bug 53686: Web Inspector: remove settings related methods from InspectorClient
https://bugs.webkit.org/show_bug.cgi?id=53686

Attachment 81069: Patch
https://bugs.webkit.org/attachment.cgi?id=81069&action=review

------- Additional Comments from Pavel Feldman <pfeldman at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=81069&action=review

> Source/WebKit/gtk/WebCoreSupport/InspectorClientGtk.cpp:68
> +	   if (inspectorSettingName == "resourceTrackingEnabled")

Nuke this?

> Source/WebKit/gtk/WebCoreSupport/InspectorClientGtk.cpp:71
> +	   if (inspectorSettingName == "xhrMonitor")

Nuke this?

> Source/WebKit/gtk/WebCoreSupport/InspectorClientGtk.cpp:74
> +	   if (inspectorSettingName == "frontendSettings")

Nuke this?

> Source/WebKit/gtk/WebCoreSupport/InspectorClientGtk.cpp:77
> +	   if (inspectorSettingName == "debuggerEnabled")

Nuke this?

> Source/WebKit/gtk/WebCoreSupport/InspectorClientGtk.cpp:80
> +	   if (inspectorSettingName == "profilerEnabled")

Nuke this?

> Source/WebKit/gtk/WebCoreSupport/InspectorClientGtk.cpp:113
> +	   if (key == "resourceTrackingEnabled" || key == "xhrMonitor"

nuke this?

> Source/WebKit/gtk/WebCoreSupport/InspectorClientGtk.cpp:133
> +	   if (key == "resourceTrackingEnabled" || key == "xhrMonitor"

nuke this?