[webkit-reviews] review denied: [Bug 52296] [Qt]Add local storage settings to QtTestBrowser option menu : [Attachment 81067] Modified code with QInputDialog::getInt() function call

[bugzilla-daemon at webkit.org]

Andreas Kling <kling at webkit.org> has denied suchi <suchi.kundu at nokia.com>'s
request for review:
Bug 52296: [Qt]Add local storage settings to QtTestBrowser option menu
https://bugs.webkit.org/show_bug.cgi?id=52296

Attachment 81067: Modified code with QInputDialog::getInt() function call 
https://bugs.webkit.org/attachment.cgi?id=81067&action=review

------- Additional Comments from Andreas Kling <kling at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=81067&action=review

Much better, some small things remaining:

> Tools/QtTestBrowser/launcherwindow.cpp:923
> +	       page()->settings()->setOfflineStorageDefaultQuota(quotaSize);   
   

What if 'quotaSize' is negative?

> Tools/QtTestBrowser/launcherwindow.cpp:924
> +	   }

This } is wrongly indented.

> Tools/QtTestBrowser/main.cpp:177
>	   int maxSize = takeOptionValue(&args,
setOfflineStorageDefaultQuotaIndex).toInt();

'maxSize' should be of an unsigned type, to match
WindowOptions::offlineStorageDefaultQuotaSize.