[webkit-reviews] review denied: [Bug 44620] Web Inspector: reflect changes to styles when they happen outside inspector. : [Attachment 80194] [PATCH] Suggested solution

[bugzilla-daemon at webkit.org]

Pavel Feldman <pfeldman at chromium.org> has denied Alexander Pavlov (apavlov)
<apavlov at chromium.org>'s request for review:
Bug 44620: Web Inspector: reflect changes to styles when they happen outside
inspector.
https://bugs.webkit.org/show_bug.cgi?id=44620

Attachment 80194: [PATCH] Suggested solution
https://bugs.webkit.org/attachment.cgi?id=80194&action=review

------- Additional Comments from Pavel Feldman <pfeldman at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=80194&action=review

> Source/WebCore/css/CSSMutableStyleDeclaration.cpp:590
> +    setNeedsStyleRecalc(true);

I'd add #if ENABLED(INSPECTOR) here and do all the work here instead of
changing the method signature.

> Source/WebCore/inspector/InspectorStyleSheet.cpp:1197
> +inline CSSStyleDeclaration* InspectorStyleSheetForInlineStyle::inlineStyle()
const

Did this help? Any stats?

> Source/WebCore/inspector/front-end/ElementsPanel.js:465
> +	   if (WebInspector.isEditingAnyField())

Is this synchronous?

> Source/WebCore/inspector/front-end/StylesSidebarPane.js:1772
> +	       WebInspector.panels.elements.modifyingStyle = true;

You should define this on sidebar.