[webkit-reviews] review granted: [Bug 50624] [GTK] Don't use a fixed size for search field icons : [Attachment 79910] New patch

[bugzilla-daemon at webkit.org]

Martin Robinson <mrobinson at webkit.org> has granted Carlos Garcia Campos
<cgarcia at igalia.com>'s request for review:
Bug 50624: [GTK] Don't use a fixed size for search field icons
https://bugs.webkit.org/show_bug.cgi?id=50624

Attachment 79910: New patch
https://bugs.webkit.org/attachment.cgi?id=79910&action=review

------- Additional Comments from Martin Robinson <mrobinson at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=79910&action=review

Okay! This should land with new DRT dumps / pixel results (for GTK+ 2.x).

> Source/WebCore/platform/gtk/RenderThemeGtk.cpp:252
> +static GtkIconSize getIconSizeForPixelSize(gint pixelSize)

I think it's more appropriate to use int instead of gint.

> Source/WebCore/platform/gtk/RenderThemeGtk.cpp:284
> +    gint fontSize = style->fontSize();

Ditto.