[webkit-reviews] review requested: [Bug 53664] XSSFilter shouldn't bother to analyze pages without "injection" characters in the request : [Attachment 81037] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Thu Feb 3 00:46:09 PST 2011
Eric Seidel <eric at webkit.org> has asked for review:
Bug 53664: XSSFilter shouldn't bother to analyze pages without "injection"
characters in the request
https://bugs.webkit.org/show_bug.cgi?id=53664
Attachment 81037: Patch
https://bugs.webkit.org/attachment.cgi?id=81037&action=review
------- Additional Comments from Eric Seidel <eric at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=81037&action=review
> Source/WebCore/html/parser/XSSFilter.h:73
> + bool m_isInitialized;
I'm always suspicious of these types of bools. should this just be part of the
state machine? Is there a better bool name than "initialzed"? m_hasParsedURL?
More information about the webkit-reviews
mailing list