[webkit-reviews] review granted: [Bug 53631] new-run-webkit-tests: hardcode the directories to scan for tests for GPU bots instead of SKIPping them : [Attachment 80980] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Feb 2 16:39:38 PST 2011


Mihai Parparita <mihaip at chromium.org> has granted Dirk Pranke
<dpranke at chromium.org>'s request for review:
Bug 53631: new-run-webkit-tests: hardcode the directories to scan for tests for
GPU bots instead of SKIPping them
https://bugs.webkit.org/show_bug.cgi?id=53631

Attachment 80980: Patch
https://bugs.webkit.org/attachment.cgi?id=80980&action=review

------- Additional Comments from Mihai Parparita <mihaip at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=80980&action=review

> Tools/Scripts/webkitpy/layout_tests/port/chromium_gpu_unittest.py:72
> +	   # These two tests are picked mostly at random, but we make sure they


Perhaps also add a positive check that we're running a compositing test (in
addition to all the negative checks)?


More information about the webkit-reviews mailing list