[webkit-reviews] review denied: [Bug 53637] [chromium] complex joining characters positioned in wrong place : [Attachment 80997] Patch

[bugzilla-daemon at webkit.org]

Tony Chang <tony at chromium.org> has denied Evan Martin <evan at chromium.org>'s
request for review:
Bug 53637: [chromium] complex joining characters positioned in wrong place
https://bugs.webkit.org/show_bug.cgi?id=53637

Attachment 80997: Patch
https://bugs.webkit.org/attachment.cgi?id=80997&action=review

------- Additional Comments from Tony Chang <tony at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=80997&action=review

r- for ews bot failure

> LayoutTests/ChangeLog:12
> +	   *
platform/chromium-linux/fast/text/international/chromium-linux-gpos-expected.ch
ecksum: Added.
> +	   *
platform/chromium-linux/fast/text/international/chromium-linux-gpos-expected.pn
g: Added.

Putting chromium-linux in the filename seems redundant.  Maybe name the test
something like true-type-gpos-table.html or complex-joining-using-gpos.html?

>
LayoutTests/platform/chromium-linux/fast/text/international/chromium-linux-gpos
-expected.txt:20
> +	     text run at (0,0) width 572: "The two words should be separated by
a space, and there should be no mark above the space."

Looks like there are 3 words.

> Source/WebCore/platform/graphics/chromium/ComplexTextControllerLinux.cpp:212
> +    int scale = 64 * size * 0x10000 / platformData.emSizeInFontUnits();

Can you put 64 and 0x10000 into constants so they are less magical?