[webkit-reviews] review granted: [Bug 53471] new-run-webkit-tests: support chromium code paths in mock_drt : [Attachment 80989] revise w/ tony's review feedback

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Feb 2 16:17:45 PST 2011


Tony Chang <tony at chromium.org> has granted Dirk Pranke <dpranke at chromium.org>'s
request for review:
Bug 53471: new-run-webkit-tests: support chromium code paths in mock_drt
https://bugs.webkit.org/show_bug.cgi?id=53471

Attachment 80989: revise w/ tony's review feedback
https://bugs.webkit.org/attachment.cgi?id=80989&action=review

------- Additional Comments from Tony Chang <tony at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=80989&action=review

> Tools/Scripts/webkitpy/layout_tests/port/mock_drt.py:238
> +	       self.uri, self.timeout, self.checksum = vals
> +	   else:
> +	       self.uri = vals[0]
> +	       self.timeout = vals[1]

Why do we bother saving the timeout if we're not going to use it?  You could
document it with a comment if you wanted.


More information about the webkit-reviews mailing list