[webkit-reviews] review granted: [Bug 53626] bufferData and bufferSubData should generate INVALID_VALUE with negative input : [Attachment 80966] Patch

[bugzilla-daemon at webkit.org]

Kenneth Russell <kbr at google.com> has granted Zhenyao Mo <zmo at google.com>'s
request for review:
Bug 53626: bufferData and bufferSubData should generate INVALID_VALUE with
negative input
https://bugs.webkit.org/show_bug.cgi?id=53626

Attachment 80966: Patch
https://bugs.webkit.org/attachment.cgi?id=80966&action=review

------- Additional Comments from Kenneth Russell <kbr at google.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=80966&action=review

Looks good; one more test case is needed though.

> LayoutTests/fast/canvas/webgl/buffer-data-array-buffer.html:44
> +glErrorShouldBe(gl, gl.INVALID_VALUE);

Please also test the bufferSubData entry point taking ArrayBufferView.