[webkit-reviews] review granted: [Bug 53604] A deleted object should never been bound again : [Attachment 80959] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Feb 2 13:44:40 PST 2011


Kenneth Russell <kbr at google.com> has granted Zhenyao Mo <zmo at google.com>'s
request for review:
Bug 53604: A deleted object should never been bound again
https://bugs.webkit.org/show_bug.cgi?id=53604

Attachment 80959: Patch
https://bugs.webkit.org/attachment.cgi?id=80959&action=review

------- Additional Comments from Kenneth Russell <kbr at google.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=80959&action=review

Looks good overall. Couple of minor nits.

> Source/WebCore/html/canvas/WebGLRenderingContext.cpp:549
> +bool WebGLRenderingContext::checkToBeBoundObject(WebGLObject* object, bool*
deleted)

Use bool& for deleted to match WebKit style and avoid the need for the ASSERT.
Also, I think "checkObjectToBeBound" would be more grammatically correct.


More information about the webkit-reviews mailing list