[webkit-reviews] review granted: [Bug 53577] A little more Heap refactoring : [Attachment 80894] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Wed Feb 2 11:16:59 PST 2011
Sam Weinig <sam at webkit.org> has granted Geoffrey Garen <ggaren at apple.com>'s
request for review:
Bug 53577: A little more Heap refactoring
https://bugs.webkit.org/show_bug.cgi?id=53577
Attachment 80894: Patch
https://bugs.webkit.org/attachment.cgi?id=80894&action=review
------- Additional Comments from Sam Weinig <sam at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=80894&action=review
>> Source/JavaScriptCore/runtime/MarkedBlock.h:65
>> + void setMarked(JSCell* cell);
>
> The parameter name "cell" adds no information, so it should be removed.
[readability/parameter_name] [5]
You don't need the parameter names here.
More information about the webkit-reviews
mailing list