[webkit-reviews] review granted: [Bug 53575] [chromium] Avoid #ifdefs in code that constructs a GraphicsContext by adding a helper class. : [Attachment 80890] v1 patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Feb 2 10:19:51 PST 2011


Kenneth Russell <kbr at google.com> has granted Darin Fisher (:fishd, Google)
<fishd at chromium.org>'s request for review:
Bug 53575: [chromium] Avoid #ifdefs in code that constructs a GraphicsContext
by adding a helper class.
https://bugs.webkit.org/show_bug.cgi?id=53575

Attachment 80890: v1 patch
https://bugs.webkit.org/attachment.cgi?id=80890&action=review

------- Additional Comments from Kenneth Russell <kbr at google.com>
I think painting/GraphicsContextBuilder.h should be added to webkit/sources in
Source/WebKit/chromium/WebKit.gyp; looks good otherwise. Leaving cq? so you can
decide whether to make this change upon landing.


More information about the webkit-reviews mailing list