[webkit-reviews] review requested: [Bug 53592] Web Inspector: Add reporting of JS heap size limit to 'console.memory' : [Attachment 80919] patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Wed Feb 2 09:14:27 PST 2011
Mikhail Naganov <mnaganov at chromium.org> has asked for review:
Bug 53592: Web Inspector: Add reporting of JS heap size limit to
'console.memory'
https://bugs.webkit.org/show_bug.cgi?id=53592
Attachment 80919: patch
https://bugs.webkit.org/attachment.cgi?id=80919&action=review
------- Additional Comments from Mikhail Naganov <mnaganov at chromium.org>
@JSC developers:
The MAX_NUM_BLOCKS const (ex. maxNumBlocks) appears to be ridiculously big --
being multiplied by BLOCK_SIZE it exceeds ULONG_MAX. Does it need to be
adjusted somehow?
On a 64-bit platform MAX_NUM_BLOCKS value is 2^59 - 1 (as
sizeof(PageAllocationAligned) = 16), and BLOCK_SIZE is 2^18.
More information about the webkit-reviews
mailing list