[webkit-reviews] review requested: [Bug 53468] Handle gpu-backed images in getUnmultipliedImageData() : [Attachment 80915] Updated fix
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Wed Feb 2 08:40:49 PST 2011
Brian Salomon <bsalomon at google.com> has asked for review:
Bug 53468: Handle gpu-backed images in getUnmultipliedImageData()
https://bugs.webkit.org/show_bug.cgi?id=53468
Attachment 80915: Updated fix
https://bugs.webkit.org/attachment.cgi?id=80915&action=review
------- Additional Comments from Brian Salomon <bsalomon at google.com>
James, I took your suggestion and made destBitmapRow a uint32_t. It's now cast
to a SkPMColor to be read and a uchar* to be written. I count 4 spaces for the
indents, though (?). I also used reinterpret_cast rather than SkTCast.
More information about the webkit-reviews
mailing list