[webkit-reviews] review granted: [Bug 53235] Web Inspector: new api for managing JavaScript breakpoints : [Attachment 80772] Patch.

[bugzilla-daemon at webkit.org]

Pavel Feldman <pfeldman at chromium.org> has granted Pavel Podivilov
<podivilov at chromium.org>'s request for review:
Bug 53235: Web Inspector: new api for managing JavaScript breakpoints
https://bugs.webkit.org/show_bug.cgi?id=53235

Attachment 80772: Patch.
https://bugs.webkit.org/attachment.cgi?id=80772&action=review

------- Additional Comments from Pavel Feldman <pfeldman at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=80772&action=review

> Source/WebCore/inspector/InspectorAgent.cpp:1012
> +void InspectorAgent::enableDebugger(bool newDebuggingSession)

newDebuggingSession -> eraseStickyBreakpoints

> Source/WebCore/inspector/InspectorAgent.h:244
> +    void enableDebugger(bool newDebuggingSession = false);

We should not have default values.

> Source/WebCore/inspector/InspectorDebuggerAgent.h:100
> +    struct Script {

You can't do structs. Yury says that Adam will come and you will get beaten.

> Source/WebCore/inspector/InspectorDebuggerAgent.h:116
> +	   int lineOffset;

I don't see why this is here.