[webkit-reviews] review canceled: [Bug 53540] Rename PLATFORM(CF) to USE(COREFOUNDATION) : [Attachment 80842] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Feb 1 23:26:52 PST 2011


Patrick R. Gansterer <paroga at paroga.com> has canceled Patrick R. Gansterer
<paroga at paroga.com>'s request for review:
Bug 53540: Rename PLATFORM(CF) to USE(COREFOUNDATION)
https://bugs.webkit.org/show_bug.cgi?id=53540

Attachment 80842: Patch
https://bugs.webkit.org/attachment.cgi?id=80842&action=review

------- Additional Comments from Patrick R. Gansterer <paroga at paroga.com>
(In reply to comment #3)
> Changing from PLATFORM to USE might be OK. But changing from CF to
COREFOUNDATION is bad since we also use CF as suffixes on file names. This
generally will make the source tree harder to read. If those file names did not
exist, then I could see the argument since CF is quite a short acronym and many
might not be aware of its meaning.
I agree, the filename suffix is a good argument against renaming to
COREFOUNDATION (at least in this patch)


More information about the webkit-reviews mailing list