[webkit-reviews] review granted: [Bug 53576] Improve readability of updateWidget by converting bool parameter to an enum : [Attachment 80891] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Tue Feb 1 22:16:39 PST 2011
Alexey Proskuryakov <ap at webkit.org> has granted Adam Barth
<abarth at webkit.org>'s request for review:
Bug 53576: Improve readability of updateWidget by converting bool parameter to
an enum
https://bugs.webkit.org/show_bug.cgi?id=53576
Attachment 80891: Patch
https://bugs.webkit.org/attachment.cgi?id=80891&action=review
------- Additional Comments from Alexey Proskuryakov <ap at webkit.org>
OK. I hope that someone actually refactors this code one day, so that we don't
pass plugin creation option in HTMLMediaElement::updateWidget(), and that
HTMLPlugInImageElement::updateWidgetIfNecessary() doesn't know about types of
plug-ins!
More information about the webkit-reviews
mailing list