[webkit-reviews] review requested: [Bug 53575] [chromium] Avoid #ifdefs in code that constructs a GraphicsContext by adding a helper class. : [Attachment 80890] v1 patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Tue Feb 1 22:10:11 PST 2011
Darin Fisher (:fishd, Google) <fishd at chromium.org> has asked for review:
Bug 53575: [chromium] Avoid #ifdefs in code that constructs a GraphicsContext
by adding a helper class.
https://bugs.webkit.org/show_bug.cgi?id=53575
Attachment 80890: v1 patch
https://bugs.webkit.org/attachment.cgi?id=80890&action=review
------- Additional Comments from Darin Fisher (:fishd, Google)
<fishd at chromium.org>
A couple notes about this patch:
1- This introduces the src/painting directory. I plan to add some more files
to that directory shortly. I feel like src/ has reached the point where it
badly needs subdirectories! (This is just a start.)
2- GraphicsContextBuilder allocates a LocalCurrentGraphicsContext object on the
Mac, even though this is not always needed. I'm not too concerned about this.
I think the simplification to the code is worth it.
More information about the webkit-reviews
mailing list